Modify provision.sh, Makefile and update README #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danialmalik
force-pushed
the
danial/fix-provision-update-readme
branch
4 times, most recently
from
1b809e5 to
22beb31
Compare
etechdevai
approved these changes
Sep 11, 2019
zubair-arbi
suggested changes
Sep 11, 2019
README.rst
Outdated
| ------------------------- | ||
|
|
||
| 1. Go do the edly directory. | ||
| 2. Run ``sudo chmod -R 777 src/`` |
There was a problem hiding this comment.
I don't think we need to set these permissions. Try setting up edly devstack without this step.
danialmalik
force-pushed
the
danial/fix-provision-update-readme
branch
from
31884ae to
9f6fa04
Compare
README.rst
Outdated
| .. code:: sh | ||
| make wordpress-shell | ||
| apt-get install php7.2 |
There was a problem hiding this comment.
This container already contains php7.3 in it so we don't need it to install.
|
|
||
| .. code:: sh | ||
| ./provision-wordpress.sh |
There was a problem hiding this comment.
While provision we face several issues:
-
Permission denied Exception for theme and plugin folder this command outside helped:
sudo chmod a+rw ../edly-wp-plugin -R
sudo chmod a+rw ../edly-wp-theme -R -
Another issue is php7.2-xml is not install on my host machine so we installed it on our own using this command:
sudo apt-get install php7.2-xml
@tehreem-sadat Faced the same issues.
danialmalik
force-pushed
the
danial/fix-provision-update-readme
branch
from
89a0e71 to
f6c4309
Compare
zubair-arbi
approved these changes
Sep 26, 2019
zubair-arbi
left a comment
zubair-arbi
left a comment
There was a problem hiding this comment.
Thanks for updating the setup guide 👍
Update README:
Update README according to Edly requirements.
Makefile:
Change "requirements" rule to install php and composer
provision.sh:
remove provision-wordpress.sh
provision-wordpress.sh:
add "#!/bin/bash" at start of file.
danialmalik
force-pushed
the
danial/fix-provision-update-readme
branch
from
a861532 to
a93321a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README:
Update README according to Edly requirements.
Makefile:
Change "requirements" rule to install php and composer
provision.sh:
remove provision-wordpress.sh
provision-wordpress.sh:
add "#!/bin/bash" at start of file.