Skip to content

Performance improvements on vector/map parsing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edma2 merged 2 commits into from
Oct 11, 2017
Merged

Performance improvements on vector/map parsing #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a84ca07
Eliminate seq overhead for unpack-n / unpack-map
leifysaurus Oct 10, 2017
7767510
Use unchecked-inc to eliminate boxed counter
leifysaurus Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/msgpack/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,24 @@
(->Ext (.readByte data-input) (read-bytes n data-input))))

(defn- unpack-n [n ^DataInput data-input opts]
(doall (for [_ (range n)] (unpack-stream data-input opts))))
(loop [i 0
v (transient [])]
(if (< i n)
(recur
(unchecked-inc i)
(conj! v (unpack-stream data-input opts)))
(persistent! v))))

(defn- unpack-map [n ^DataInput data-input opts]
(apply hash-map (unpack-n (* 2 n) data-input opts)))
(loop [i 0
m (transient {})]
(if (< i n)
(recur
(unchecked-inc i)
(assoc! m
(unpack-stream data-input opts)
(unpack-stream data-input opts)))
(persistent! m))))

(defn unpack-stream
([^DataInput data-input] (unpack-stream data-input nil))
Expand Down