Open
Conversation
- views/index.hbs, corrects a misspelling of maxiumum-scale with maximum-scale. A fix for mobiles. - earls.js, it binds with all local IPs using app.listen but setting only default port. Added an EARLS_HOSTNAME with defaults = "". It binds anyway with all local IPs. - earls.js, changed PORT with EARLS_PORT for compatibility: PORT and HOSTNAME are commonly used on Unix, avoiding conflicts. - earls.js, current release use HTTPS for tweets & accounts but HTTP for avatar (profile_image_url). Using the profile_image_url_https it solves most crash/errors when earls publish lots of URLs and avatars. - README.md, updates for descriptions of EARLS_PORT and EARLS_HOSTNAME.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maximum-scale. A fix for mobiles.
only default port. Added an EARLS_HOSTNAME with defaults = "". It binds
anyway with all local IPs.
HOSTNAME are commonly used on Unix, avoiding conflicts.
for avatar (profile_image_url). Using the profile_image_url_https it
solves most crash/errors when earls publish lots of URLs and avatars.