Applying patch to enable password change from django admin #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocococosti
force-pushed
the
coa/patch-change-pass-from-admin
branch
from
0b8b37d to
7deba64
Compare
Member
|
LGTM @cocococosti |
jfavellar90
approved these changes
Oct 7, 2019
morenol
approved these changes
Oct 7, 2019
Contributor
Author
|
Setting ENABLE_CHANGE_USER_PASSWORD_ADMIN directly in the microsite settings didn't work locally, it was taking a None value. @morenol says it may be because the setting is initialized before the eox tenant signal. It worked when I added the setting directly in lmv.env.json with a true value so it'll work if we add the setting directly in customer data, fyi @jfavellar90 |
Member
|
@cocococosti this is not a tenant-aware feature flag. We activate it globally, reason why we must manage this via ansible |
Contributor
Author
|
ok, then I'll merge once the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a patch (from https://github.com/edx/edx-platform/pull/21616) to enable user password change from the django admin page with a feature setting.
Tested in dev and works OK.