Added another format for registration field options #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
reviewed
Feb 2, 2021
| if field_options: | ||
| field_options = [(six.text_type(option.lower()), option) for option in field_options] | ||
| try: | ||
| field_options = [(six.text_type(value.lower()), name) for value, name in field_options.items()] |
Contributor
There was a problem hiding this comment.
This looks good to me. I think that we should try first the old format (field_options = [(six.text_type(value.lower()), value) for value in field_options]) and if that fails use the new format. What do you think?
Contributor
Author
There was a problem hiding this comment.
But how the old format would fail? 🤔
morenol
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new format for registration field options, it allows us to use:
Format 1:
"options": [option1, ...., optionN]
Format 2:
"options": {"value": "name", ..., "valueN": "nameN"}