-
Notifications
You must be signed in to change notification settings - Fork 6
JU-6: add support for openedx-events #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
405dc0e to
ec206aa
Compare
7207373 to
d500cd4
Compare
d500cd4 to
31f5ceb
Compare
mariajgrimaldi
commented
Nov 2, 2021
Member
|
@mariajgrimaldi How much does this differ from the upstream code? Where did you have to make adjustments if any? |
Contributor
Author
|
Good question, @MoisesGSalas. Thanks.
The rest is the same:
|
4abfc60 to
74ee7ac
Compare
6df8bbd to
4fd9486
Compare
4fd9486 to
b6246c1
Compare
MoisesGSalas
approved these changes
Nov 4, 2021
felipemontoya
approved these changes
Nov 4, 2021
MaferMazu
approved these changes
Nov 4, 2021
* Add STUDENT_REGISTRATION_COMPLETED event after the user's registration * Add SESSION_LOGIN_COMPLETED event after the user's login session * Add COURSE_ENROLLMENT_CREATED event after the user's enrollment creation * Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update * Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment * Add CERTIFICATE_CREATED after the user's certificate generation has been completed * Add CERTIFICATE_CHANGED: after the certification update has been completed * Add CERTIFICATE_REVOKED: after the certificate revocation has been completed * Add COHORT_MEMBERSHIP_CHANGED: when a cohort membership update ends
b6246c1 to
0a34a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Open edX Events in Limonero. These events are part of the OEP-50: Hooks Extension Framework implementation plan.
Since the OEP-50 publication, there has been a lot of discussion surrounding the design of this new extension point; I'll address some here for context:
OpenEdxPublicSignal-a subclass of Django signals- is used to create each event.send_eventis the method that replacessendandsend_robust.STUDENT_REGISTRATION_COMPLETEDis sent after the user's registration.For an overall understanding of the design, check out the Open edX Events ADRs and discussions:
Supporting information
Discuss on Hooks Extension Framework:
https://discuss.openedx.org/t/configuration-for-the-hooks-extension-framework/4527/
Testing instructions
pip install openedx-events==0.6.0