Skip to content

FFI-8 P3: Fix python package installation#606

Merged
MoisesGSalas merged 1 commit intoedunext/limonero.masterfrom
li/ednx/FFI-8_P3
Dec 23, 2021
Merged

FFI-8 P3: Fix python package installation#606
MoisesGSalas merged 1 commit intoedunext/limonero.masterfrom
li/ednx/FFI-8_P3

Conversation

@MoisesGSalas
Copy link
Member

@MoisesGSalas MoisesGSalas commented Dec 23, 2021 •
edited
Loading

Description

  • Ensure the correct dependencies are installed even with a broken version in the cache.
  • Move from continue-on-error: true to fail-fast: false to avoid green checks even when all jobs failed.
  • Install eduNEXT dependencies on the pylint workflows. There was an import error due to eox-tenant that broke the pylint run. Because pylint is run via paver the exit code is 0 when an error is found and the result of the job was a success. This pylint violations seem to have been silenced for a few weeks now.

johanseto
johanseto approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@johanseto johanseto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, this way we discover some pylint issues we have passed by the paver in the tests.
So in the future, we can change them.

@MoisesGSalas MoisesGSalas merged commit 4ce9827 into edunext/limonero.master Dec 23, 2021
@MoisesGSalas MoisesGSalas mentioned this pull request Dec 23, 2021
Merged
@mariajgrimaldi mariajgrimaldi mentioned this pull request Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@black-redoc black-redoc Awaiting requested review from black-redoc

@MaferMazu MaferMazu Awaiting requested review from MaferMazu

2 more reviewers

@johanseto johanseto johanseto approved these changes

@JuanDavidBuitrago JuanDavidBuitrago JuanDavidBuitrago approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

limonero

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoisesGSalas @johanseto @JuanDavidBuitrago @MaferMazu