Skip to content

Conversation

@mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Jun 13, 2022

Description

This PR adds:

  • HomepageRenderStarted filter definition
  • CatalogRenderStarted filter definition

And their respective integrations. These changes are implemented in the context of the Open edX Demo site.

Testing instructions

  1. Install openedx-demo-plugin main branch
  2. Add to your site settings:
"course_org_filters": {
     "demo", ...., "Public"
}
  1. Then create courses using the org "Public". You'll be able to see them on the dashboard but not on the homepage/catalog

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/restriction-filters branch from 306977c to a1d0dc5 Compare June 14, 2022 18:32
@mariajgrimaldi mariajgrimaldi changed the title Mjg/restriction filters feat: add catalog/homepage filters definitions Jun 14, 2022
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/restriction-filters branch from a1d0dc5 to f6f88fa Compare June 14, 2022 19:02
@MoisesGSalas
Copy link
Member

does the branch edunext/limonero.openedx have any defined purpose? Is it going to be used in the future? we have ednx-release/limonero.master, and master as actively supported branches. This one is going to keep in sync with any of them?

@mariajgrimaldi
Copy link
Contributor Author

mariajgrimaldi commented Jun 15, 2022

edunext/limonero.openedx has the filters most up-to-date which master does not, that's the main reason I created it.

I believe @Ian2012 is working on getting the master branch up to date with the release branch (which already has the filters we need, exactly added by me in this PR). So we could add the changes to master after that happens.

Either way, I'm curious about what you think @Alec4r, are these changes relevant for master? how do we know? 🤔

@mariajgrimaldi mariajgrimaldi changed the base branch from edunext/limonero.openedx to ednx-release/limonero.master June 23, 2022 18:50
@mariajgrimaldi mariajgrimaldi changed the base branch from ednx-release/limonero.master to edunext/limonero.openedx June 23, 2022 18:53
@mariajgrimaldi mariajgrimaldi changed the base branch from edunext/limonero.openedx to ednx-release/limonero.master June 23, 2022 18:56
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/restriction-filters branch from f6f88fa to faa5b3f Compare June 23, 2022 20:50
@mariajgrimaldi mariajgrimaldi merged commit 9e687ef into ednx-release/limonero.master Jun 24, 2022
JuanDavidBuitrago pushed a commit that referenced this pull request Sep 3, 2022
feat: backport HomepageRenderStarted and CatalogRenderStarted filters
ErickMurillo pushed a commit that referenced this pull request Feb 12, 2024
feat: backport HomepageRenderStarted and CatalogRenderStarted filters
DeimerM added a commit that referenced this pull request Feb 14, 2024
Merge pull request #659 from eduNEXT/MJG/restriction-filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants