Skip to content

Conversation

@mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Oct 16, 2024

Description

This PR adds our default license for public repositories but with a limited support warning. If this PR is merged, the workflow will be (explicit) publicly available for other organizations to use.

The warning addresses this concern: #1 (comment)

@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner October 16, 2024 11:25
@magajh
Copy link
Contributor

magajh commented Oct 22, 2024

Thanks @mariajgrimaldi, this looks good to me!
I was reading that reusable workflows often use permissive licenses like MIT or Apache. Did we consider this, or is there a specific reason for choosing GPLv3?

@mariajgrimaldi
Copy link
Contributor Author

mariajgrimaldi commented Oct 22, 2024

Thanks for bringing that up, @magajh! I considered MIT, proprietary, and AGPL-3.0. The AGPL-3.0 license still allows public use without restriction unless the application is modified and publicly distributed. Although it is true that AGPL-3.0 and MIT both work for this use case, I chose the latter mainly because most OSS products are under that license and it's not as restrictive.

I don't think which license (AGPL, MIT, or Apache) we use matters in the end, so we could also go with MIT (less restrictive) with the no-support note -- which is the most relevant part of this PR. Let me know!

Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @mariajgrimaldi! I don't have any objections to using this license, so I'm approving this

@mariajgrimaldi mariajgrimaldi merged commit d857639 into main Oct 22, 2024
@mariajgrimaldi mariajgrimaldi deleted the MJG/license branch October 22, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants