Skip to content

Powershell - Passing arguments that contain quote characters #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edumserrano merged 3 commits into from
Jul 17, 2023
Merged

Powershell - Passing arguments that contain quote characters #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68f9aba
Replicate issue with double quotes
edumserrano Jul 17, 2023
69bf5ed
Update pwsh from 7.2.2 to 7.3.6
edumserrano Jul 17, 2023
eb729d5
Update test assertion
edumserrano Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
"nuget-version": "1.0.13-alpha",
"auto-generate-release-notes": "Yes",
"push-nuget": "",
"custom-release-notes": "## Custom release notes\n\nTest 123\n\nAnother line:\n- point 1\n- point 2\n- point 3",
"custom-release-notes": "## Custom release notes\n\nTest 123\n\"line with double quotes\"\n\nAnother line:\n- point 1\n- point 2\n- point 3",
"operating-systems": {
"macos": true,
"windows": true,
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

FROM mcr.microsoft.com/dotnet/runtime:7.0-alpine AS base
# install powershell as per https://docs.microsoft.com/en-us/powershell/scripting/install/install-alpine?view=powershell-7.2
ARG PWSH_VERSION=7.3.6
RUN apk add --no-cache \
ca-certificates \
less \
Expand All @@ -17,7 +18,7 @@ RUN apk add --no-cache \
icu-libs \
curl
RUN apk -X https://dl-cdn.alpinelinux.org/alpine/edge/main add --no-cache lttng-ust
RUN curl -L https://github.com/PowerShell/PowerShell/releases/download/v7.2.2/powershell-7.2.2-linux-alpine-x64.tar.gz -o /tmp/powershell.tar.gz
RUN curl -L https://github.com/PowerShell/PowerShell/releases/download/v${PWSH_VERSION}/powershell-${PWSH_VERSION}-linux-alpine-x64.tar.gz -o /tmp/powershell.tar.gz
RUN mkdir -p /opt/microsoft/powershell/7
RUN tar zxf /tmp/powershell.tar.gz -C /opt/microsoft/powershell/7
RUN chmod +x /opt/microsoft/powershell/7/pwsh
Expand Down
2 changes: 1 addition & 1 deletion ...ueFormsParser/tests/GitHubIssuesParserCli.Tests/CliCommands/ParseIssueFormCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public async Task ParseIssueFormCommandTest1()
issueFormJson.NuGetVersion.ShouldBe("1.0.13-alpha");
issueFormJson.AutoGenerateReleaseNotes.ShouldBe("Yes");
issueFormJson.PushNuget.ShouldBeEmpty();
issueFormJson.CustomReleaseNotes.ShouldBe($"## Custom release notes{Environment.NewLine}{Environment.NewLine}Test 123{Environment.NewLine}{Environment.NewLine}Another line:{Environment.NewLine}- point 1{Environment.NewLine}- point 2{Environment.NewLine}- point 3");
issueFormJson.CustomReleaseNotes.ShouldBe($"## Custom release notes{Environment.NewLine}{Environment.NewLine}Test 123{Environment.NewLine}\"line with double quotes\"{Environment.NewLine}{Environment.NewLine}Another line:{Environment.NewLine}- point 1{Environment.NewLine}- point 2{Environment.NewLine}- point 3");
issueFormJson.OperatingSystems.ShouldNotBeNull();
issueFormJson.OperatingSystems.MacOS.ShouldNotBeNull();
issueFormJson.OperatingSystems.MacOS.ShouldBe(true);
Expand Down
1 change: 1 addition & 0 deletions GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/TestFiles/IssueBody.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ _No response_
## Custom release notes

Test 123
"line with double quotes"

Another line:
- point 1
Expand Down