[MCKIN-7759] Remove usage of CourseAggregatedMetaData since it is no longer in use.#208
[MCKIN-7759] Remove usage of CourseAggregatedMetaData since it is no longer in use.#208
Conversation
xitij2000
force-pushed
the
kshitij/mckin-7759
branch
from
e045a47 to
5bcab73
Compare
| serializer_context.update({ | ||
| 'course_id': self.course_key, | ||
| 'default_fields': default_fields, | ||
| 'course_meta_data': self.course_meta_data, |
There was a problem hiding this comment.
This isn't being used the serializer any more so remove it.
| """ | ||
| SignalHandler.course_published.connect( | ||
| listener_in_course_metadata, dispatch_uid='course_metadata' | ||
| ) |
There was a problem hiding this comment.
Since course metatdata is no longer being used, we no longer need to keep it up to date.
| url(r'^organizations/*', include('edx_solutions_organizations.urls')), | ||
| url(r'^mobile/v1/', include('edx_solutions_api_integration.mobile_api.urls')), | ||
| url(r'^imports/*', include('edx_solutions_api_integration.imports.urls')), | ||
| url(r'^courses_metadata/', include('course_metadata.urls')), |
There was a problem hiding this comment.
I could not see this API being used by Apros.
There was a problem hiding this comment.
Is this connected to the old progress code? I'm not familiar with the CourseAggregatedMetadata model or this api. Do you know what it was intended to do?
There was a problem hiding this comment.
I've added it back since it wasn't really in scope. I was just cleaning up some unused code while I was at it, but I don't want to blow up the scope and review time too much here.
xitij2000
force-pushed
the
kshitij/mckin-7759
branch
from
3f73e2e to
0f64f5f
Compare
xirdneh
left a comment
xirdneh
left a comment
There was a problem hiding this comment.
👍
- I tested this:
- Ran this in local Vagrant devstack.
- I read through the code
[ ] I checked for accessibility issues[ ] Includes documentation[ ] I made sure any change in configuration variables is reflected in the corresponding
client'sconfiguration-securerepository.
xitij2000
force-pushed
the
kshitij/mckin-7759
branch
from
7ad6d30 to
28705c0
Compare
5 participants
The data CourseAggregatedMetaData was storing is now provided by the completion aggregator, code using it and signals keeping it in sync can be removed.