This repository was archived by the owner on Feb 27, 2024. It is now read-only.
MCKIN-9499: update course overview and user courses api to return image urls #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaqib52
requested review from
naeem91 and
umarmughal824
and removed request for
naeem91
umarmughal824
approved these changes
May 16, 2019
nasirhjafri
added a commit
that referenced
this pull request
Jun 21, 2019
This reverts commit 86226fa.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates course overview and user courses API to return course overview image set rather than returning full-sized raw image, which can sometimes be huge in size and take a lot of time to load causing bad user experience.
Testing Notes:
This change requires course overview image sets enabled, to enable it go to course overview images config page in django admin and add new config.