feat: functionality improvements to util script #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-all-repos-in-directory enhancements: * -q flag to make it less noisy * -c flag so that it will do garbage collection and committed branch cleanup * -d flag so you can specify a top-level directory to run in without any of these flags, behavior should be unchanged.
justinhynes
approved these changes
Feb 25, 2025
Contributor
justinhynes
left a comment
justinhynes
left a comment
There was a problem hiding this comment.
FWIW -- I'm not very adept at shell scripting, but I pulled and tested it and seems good! It looks like it did what was desired/expected and I like the cleanup options.
One nit -- I had to chmod +x the script to make it executable once I pulled down your branch. Can we update the permissions before merge?
JH pointed out that the file permissions should be 755.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull-all-repos-in-directory enhancements:
without any of these flags, behavior should be unchanged.
I've completed each of the following or determined they are not applicable: