-
Notifications
You must be signed in to change notification settings - Fork 12
fix: BOMS-235 Create script to set up remotes for devstack #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: BOMS-235 Create script to set up remotes for devstack #184
Conversation
e70e048 to
3656bc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements a git remote setup system for devstack repositories to handle forked repositories between edx and openedx organizations. The script automatically configures appropriate remotes for developers working with forks.
- Adds remote setup functionality that renames origin to the primary organization and adds the complementary remote
- Creates a comprehensive test suite to validate the remote setup behavior across different repository types
- Integrates remote setup into the existing make clone workflow for automatic configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| repo.sh | Adds core remote setup logic, forked repository configuration map, and new command handler |
| Makefile | Integrates remote setup command and adds automatic setup to clone operations |
| test_repo.sh | Comprehensive test suite for validating remote setup functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ipt-to-set-up-remotes-for-devstack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.
Comments suppressed due to low confidence (1)
repo.sh:1
- [nitpick] Large hard-coded FORKED_REPOS list duplicates data already implicit in repos/non_release_repos and increases drift risk; consider generating this from existing arrays (filtering those present in both orgs) or loading from a single config file to centralize maintenance.
#!/usr/bin/env bash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
timmc-edx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description:
Developers need to set up git remotes for forked repositories to access both edx and openedx organizations. Script was a need to be prepared to handle the remote , origin , personal and non-forked repos.
Solution:
make dev.setup-remotesand automatic setup during clone operationsRun test file:
Make the test file executable:
chmod +x test_repo.shRun dry run
./test_repo.shExpected dry-run output:
JIRA Ticket:
BOMS-235