Draft
Conversation
tonytw1
force-pushed
the
prebuilt-base-images
branch
6 times, most recently
from
4ac11c9 to
287fc7c
Compare
tonytw1
force-pushed
the
dev10
branch
2 times, most recently
from
5768642 to
aa17300
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
from
287fc7c to
174de00
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
3 times, most recently
from
849b1a2 to
b6dc325
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
from
b6dc325 to
b35d29f
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
8 times, most recently
from
60c7c71 to
973f901
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
3 times, most recently
from
214dcb9 to
a572a14
Compare
…select check box is clobbered by click through to single image screen.
…selects from preview. Attach the onImageClick behaviour from results so the entire image toggles the selection when in selection mode and the click is handled by the range selection aware code.
Read back optional webTitle and sectionId correctly from dynamoDB item.
HIEC is actually a subset of HIEF.
…not always been available on the JSON edits record. Editing the metadata of an image with no usage rights overrides seems to remove the field, causing getUsageRights to start HTTP 500 erroring.
Image loader and cropper use prebuilt JDK + VIPS base image. Include sbt supplied apt-gets in base image. No apt-get outside of the base images.
… alpha channel. Cast out of LAB to sRGB to get a reliable is alpha check. Some LAB VipsInterpretations seem to be a wierd 4 band format even if they have no alpha.
…RETATION_LAB to INTERPRETATION_sRGB before evaluating.
tonytw1
force-pushed
the
prebuilt-base-images
branch
from
b9f4afc to
2a02297
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
from
2a02297 to
c0359ad
Compare
tonytw1
force-pushed
the
prebuilt-base-images
branch
from
549f05c to
74cebb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?