Skip to content

fix: improve error handling by using form-level fieldMeta for persist… #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakhBeth merged 1 commit into from
Dec 3, 2025
Merged

fix: improve error handling by using form-level fieldMeta for persist… #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-lines-stop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect-app/vue-components": patch
---

fix: improve error handling by using form-level fieldMeta for persistence across re-mounts
11 changes: 9 additions & 2 deletions packages/vue-components/src/components/OmegaForm/OmegaInternalInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ const fieldApi = props.field

const fieldState = useStore(fieldApi.store, (state) => state)

// Get errors from form-level fieldMeta (persists across Field re-mounts)
const formFieldMeta = useStore(fieldApi.form.store, (state) => state.fieldMeta)

const fieldType = computed(() => {
if (props.type) return props.type
if (props.meta?.type === "string") {
Expand All @@ -95,8 +98,12 @@ const fieldType = computed(() => {

props.register(computed(() => ({ name: props.field.name, label: props.label, id })))

// workaround strange tanstack form issue where the errors key becomes undefined ???
const _errors = computed(() => fieldState.value.meta.errors ?? [])
// Get errors from form-level fieldMeta instead of field-level state
// This ensures errors persist when Field components re-mount due to :key changes
const _errors = computed(() => {
const fieldMeta = formFieldMeta.value[props.field.name] as any
return fieldMeta?.errors ?? []
})
const errors = computed(() =>
// eslint-disable-next-line @typescript-eslint/no-explicit-any
_errors.value.map((e: any) => e?.message).filter(Boolean)
Expand Down