Add option to enable TLS for minio #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
2 tasks
| ), | ||
| Readiness: e2e.NewHTTPReadinessProbe("metrics", "/health", 200, 204), | ||
| }, | ||
| e2e.StartOptions{ |
There was a problem hiding this comment.
Just a minor nit here. Why modify the spacing? ;)
Collaborator
Author
There was a problem hiding this comment.
This is mdox, I think we were printing an extra bracket earlier, which caused the syntax to be a bit off. 🙂
matej-g
approved these changes
Jan 19, 2023
Collaborator
matej-g
left a comment
matej-g
left a comment
There was a problem hiding this comment.
Looking good, thanks! Minor nits, optional 🙂
| 200, | ||
| ) | ||
| } else { | ||
| envVars = append(envVars, "ENABLE_HTTPS="+"0") |
Collaborator
There was a problem hiding this comment.
What's the default, do we need to specify this if we don't want to enable HTTPS? 🤔
Collaborator
Author
There was a problem hiding this comment.
Yeah I'll address in follow-up
| ) | ||
| } else { | ||
| envVars = append(envVars, "ENABLE_HTTPS="+"0") | ||
| command = command + fmt.Sprintf( |
Collaborator
There was a problem hiding this comment.
Nit: we could have one command var instead of two separate in each branch and just (not) include --certs-dir depending on HTTPS option
Rasek91
pushed a commit
to Rasek91/efficientgo-e2e
that referenced
this pull request
May 13, 2023
* Add option to enable TLS for minio Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix readiness probe Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix lint Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to enable TLS for minio by generating certs, adjusting commands and readiness probes accordingly.