Add check for netcat #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without netcat install the wait-for script simply times out and it is confusing whether the timeout is due to lack of netcat or because the port didn't come up. Adding this check prevents wait-for script from coming up when netcat isn't installed.
Author
trbolat
approved these changes
Dec 21, 2019
|
I've made a "hard" fork of this repo and integrated some open PR's. Maybe someone finds it helpful https://github.com/xoxys/wait-for |
|
Sorry for taking so long 😓 Heads up, a similar fix landed through #22 a while back, so I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without netcat install the wait-for script simply times out and it is confusing whether the timeout is due to lack of netcat or because the port didn't come up. Adding this check prevents wait-for script from coming up when netcat isn't installed.