deps: tegg dns cache plugin

[Dipper30]

Deps: include tegg-dns-cache plugin packages

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @Dipper30, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's dependency structure by introducing the @eggjs/tegg-dns-cache plugin for managing DNS caching. This change aims to externalize and modularize DNS caching functionality, moving away from the built-in httpclient option, which is now marked for deprecation. The update promotes a more robust and specialized approach to DNS resolution within the application.

Highlights

• Dependency Update: Added @eggjs/tegg-dns-cache as a production dependency and @eggjs/tegg-config, @eggjs/tegg-plugin as development dependencies.
• DNS Cache Deprecation: Marked the enableDNSCache option within config.httpclient as deprecated, recommending the use of the new @eggjs/tegg-dns-cache plugin instead.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​eggjs/​tegg-config@​3.69.0
	@​eggjs/​tegg-plugin@​3.69.0
	@​eggjs/​tegg-dns-cache@​3.69.0

View full report

[gemini-code-assist]

Code Review

This pull request correctly adds the @eggjs/tegg-dns-cache plugin and deprecates the old built-in DNS cache feature, which is a good move towards modularity. I've added a comment to improve the deprecation notice in the configuration. I also recommend updating the documentation in site/docs/core/httpclient.md and site/docs/core/httpclient.zh-CN.md to reflect this change and guide users to the new plugin.

[gemini-code-assist]

To make the deprecation clearer, it's good practice to explicitly mention that all related options for the built-in DNS cache (enableDNSCache, dnsCacheLookupInterval, and dnsCacheMaxLength) are being deprecated. This will help prevent confusion for developers.

Suggested change

	/**
	* @deprecated This option is deprecated.
	* Use @eggjs/tegg-dns-cache instead.
	*/
	/**
	* @deprecated The built-in DNS cache feature is deprecated. Use `@eggjs/tegg-dns-cache` instead.
	* This also deprecates `dnsCacheLookupInterval` and `dnsCacheMaxLength`.
	*/