refactor: upgrade koa-session, support egg2. [BREAKING CHANGE]#10
Merged
dead-horse merged 2 commits intomasterfrom Nov 9, 2017
Merged
refactor: upgrade koa-session, support egg2. [BREAKING CHANGE]#10dead-horse merged 2 commits intomasterfrom
dead-horse merged 2 commits intomasterfrom
Conversation
Member
|
这个库没有开 win 的测试？ |
Member
Author
|
依赖了 redis-server |
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 17 20 +3
=====================================
+ Hits 17 20 +3
Continue to review full report at Codecov.
|
atian25
reviewed
Nov 9, 2017
| 'benchmark', | ||
| ], | ||
| devdep: [ | ||
| 'egg', |
Member
Author
There was a problem hiding this comment.
不会，dev 不会去除，因为现在依赖的是 next tag，所以就没必要在这里写了
atian25
approved these changes
Nov 9, 2017
Member
|
回头 egg guide docs 那边也要改改对应的 generator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
drop node <8 support, so it is a breaking change.
eggjs/egg#1564