Skip to content

feat: warn if httpOnly set to false#13

Merged
fengmk2 merged 1 commit intomasterfrom
warn-httponly-false
Apr 28, 2019
Merged

feat: warn if httpOnly set to false#13
fengmk2 merged 1 commit intomasterfrom
warn-httponly-false

Conversation

@dead-horse
Copy link
Copy Markdown
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@dead-horse dead-horse requested a review from fengmk2 April 28, 2019 09:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2019

Codecov Report

Merging #13 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   96.15%   96.42%   +0.27%     
==========================================
  Files           4        4              
  Lines          26       28       +2     
==========================================
+ Hits           25       27       +2     
  Misses          1        1
Impacted Files Coverage Δ
app.js 90% <100%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3168fb7...b9c4576. Read the comment docs.

@fengmk2 fengmk2 merged commit 39629ab into master Apr 28, 2019
@fengmk2 fengmk2 deleted the warn-httponly-false branch April 28, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants