Merged
Conversation
Bump egglog version which changes running commands to return structured output and adds fields on the serialized e-graph to show if functions were omitted.
Member
Author
|
@actions-user changelog |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the egglog version, updating the dependencies to use the main branch versions and modifying the Python bindings to work with structured command outputs instead of string outputs.
- Updates
run_programmethod to return structuredCommandOutputobjects instead of strings - Adds new fields to
SerializedEGraphfor tracking truncated and discarded functions - Refactors command handling to use structured output types
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/serialize.rs | Adds new fields for tracking function truncation/discard status |
| src/lib.rs | Registers new Python classes for structured command outputs |
| src/egraph.rs | Updates run_program to return structured outputs and removes legacy report methods |
| src/conversions.rs | Implements new command output types and updates function command naming |
| python/tests/test_py_object_sort.py | Updates tests to use new structured output format |
| python/tests/test_bindings.py | Updates tests to use new structured output format |
| python/egglog/exp/array_api.py | Removes type ignore comment |
| python/egglog/egraph_state.py | Updates function command reference |
| python/egglog/egraph.py | Refactors to use structured command outputs |
| python/egglog/bindings.pyi | Updates type definitions for new structured outputs |
| docs/changelog.md | Documents the version bump |
| Cargo.toml | Updates dependency versions to main branch |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
671a431 to
44f6214
Compare
CodSpeed Instrumentation Performance ReportMerging #335 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump egglog version which changes running commands to return structured output and adds fields on the serialized e-graph to show if functions were omitted.
Follow up PRs will expose this functionality at the high level.