Emit warnings when functions omitted when visualizing#336
Merged
saulshanabrook merged 3 commits intomainfrom Sep 1, 2025
Merged
Emit warnings when functions omitted when visualizing#336saulshanabrook merged 3 commits intomainfrom
saulshanabrook merged 3 commits intomainfrom
Conversation
Adds support for upstream egglog change to emit when serializing and functions or calls were omitted based on maxmimums
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds warning support when visualizing egglog graphs to alert users when functions or calls are omitted due to maximum limits. This provides better feedback about incomplete visualizations.
- Implements warning emission when functions are discarded or truncated during serialization
- Adds helper method to map egglog function names to Python function names for clearer warnings
- Includes tests to verify warning behavior for both max_functions and max_calls_per_function limits
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/egglog/egraph_state.py | Adds possible_egglog_functions method to map egglog function names to Python function strings |
| python/egglog/egraph.py | Integrates warning emission in _serialize method when functions are discarded or truncated |
| python/tests/test_high_level.py | Adds test cases to verify warning behavior for serialization limits |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
@actions-user changelog |
CodSpeed Instrumentation Performance ReportMerging #336 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for upstream egglog change to emit when serializing and functions or calls were omitted based on maxmimums