Add PyObject.to_int() method returning i64#394
Closed
nelhage wants to merge 2 commits intoegraphs-good:mainfrom
Closed
Add PyObject.to_int() method returning i64#394nelhage wants to merge 2 commits intoegraphs-good:mainfrom
nelhage wants to merge 2 commits intoegraphs-good:mainfrom
Conversation
Add the py-to-int primitive that extracts a Python integer as i64, complementing the existing from_int method for bidirectional conversion.
CodSpeed Performance ReportMerging #394 will not alter performanceComparing Summary
|
saulshanabrook
approved these changes
Dec 18, 2025
Member
saulshanabrook
left a comment
There was a problem hiding this comment.
Thank you! Could you add a little test for this in test_high_level?
Yeah the current set of primitives with py objects are rather arbitrary, would be good to fill them out more.
Author
|
Done! Looks like the test failures are infra issues, at a glance. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the py-to-int primitive that extracts a Python integer as i64, complementing the existing from_int method for bidirectional conversion.
Implemented using Claude Code, but reviewed by me before submission. I would find this useful for some current work, where I end up moving between the Python domain and the egglog domain fairly heavily.