Skip to content

Conversation

@mathieucarbou
Copy link
Member

@mathieucarbou mathieucarbou commented Jan 4, 2023

Backport to 3.9 of #3105

This PR adds a docker folder in the Ehcache kit with instructions on how to build the 3 images, plus the README to place on Docker Hub.

  • ehcache-server ehcache-terracotta-server
  • terracotta-voter-oss ehcache-terracotta-voter
  • terracotta-config-tool-oss ehcache-terracotta-config-tool

Notes:

  • I have manually tested them, since it is not yet possible to add docker tests in Ehcache
  • Naming still to be discussed
  • Gradle / Docker build scripts and deployment to hub.docker.com still to be done in a subsequent PR
  • A cherry-pick to the release/3.9 branch can be made once merged

Some ref regarding these required perm / uid:0 with OpenShift (also others): https://docs.openshift.com/container-platform/3.11/creating_images/guidelines.html#openshift-specific-guidelines

TO TEST:

gw assemble
gw distDir
cd clustered/clustered-dist/build/kit/
./docker/buildAndTest.groovy

@mathieucarbou mathieucarbou self-assigned this Jan 4, 2023
@mathieucarbou mathieucarbou changed the base branch from master to release/3.9 January 4, 2023 16:33
@mathieucarbou
Copy link
Member Author

Updated READMEs to add the necessary header and footer (licensing, etc) required to be deployed on hub.docker.com

@mathieucarbou
Copy link
Member Author

Added ./docker/buildAndTest.groovy to automate building and testing of images

@mathieucarbou
Copy link
Member Author

Added 3.9-SNAPSHOT tag to built images

@mathieucarbou mathieucarbou marked this pull request as ready for review January 9, 2023 17:17
@mathieucarbou mathieucarbou marked this pull request as draft January 11, 2023 13:49
@mathieucarbou
Copy link
Member Author

  • Changed image names to:

    terracotta/ehcache-terracotta-server
    terracotta/ehcache-terracotta-config-tool
    terracotta/ehcache-terracotta-voter

  • Updated ./docker/buildAndTest.groovy to include an Ehcache put/get test

  • Fixed base images to azul/zulu-openjdk-alpine:17.0.5-17.38.21

  • Added resource filtering in Groovy build script to generate docker files with the correct project version

@mathieucarbou mathieucarbou marked this pull request as ready for review January 11, 2023 17:06
@jhouserizer jhouserizer merged commit ef419d7 into ehcache:release/3.9 Jan 17, 2023
@mathieucarbou mathieucarbou deleted the docker/3.9 branch April 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants