Issue 2494 Refix #3274
Merged
Issue 2494 Refix #3274
+117
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Ehcache manager directly
chrisdennis
force-pushed
the
issue-2494-refix
branch
from
1cb42e0 to
c85a888
Compare
jhouserizer
approved these changes
Aug 21, 2025
Member
jhouserizer
left a comment
jhouserizer
left a comment
There was a problem hiding this comment.
Pretty hairy changes, but I don't see anything amiss.
chrisdennis
requested review from
prasantakumar82
and removed request for
tmesic99
Member
Author
|
Local testing confirms this fixes the issue in the spring-boot test, and triggers no other failures there. |
prasantakumar82
approved these changes
Aug 29, 2025
Contributor
prasantakumar82
left a comment
prasantakumar82
left a comment
There was a problem hiding this comment.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move back here to a non-lazy approach to building the map of 107 wrappers. This means we generate all the wrappers up front, and then we generate new wrappers by listening for added caches, and remove when we see a cache removed. This should mean that direct additions/removals to the Ehcache manager will be immediately reflected in the JSR-107 manager.