Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR upgrades py-torch to 2.7.1 or later (to unpin py-sympy used by acts, and to support newer CUDA).

Copilot AI review requested due to automatic review settings December 26, 2025 15:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to upgrade the py-torch package requirement from version 2.5.1 to version 2.7.1 or later, with the stated goals of unpinning py-sympy used by acts and supporting newer CUDA versions.

Key Changes:

  • Modified py-torch version constraint from a pinned version '@2.5.1' to a minimum version requirement '@2.7.1:'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc enabled auto-merge (squash) December 26, 2025 16:19
Copilot AI review requested due to automatic review settings January 5, 2026 00:20

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings January 5, 2026 00:34

This comment was marked as resolved.

@wdconinc
Copy link
Contributor Author

Despite the cxxflags, there are still incompatible-pointer type errors for arm64, https://github.com/eic/containers/actions/runs/21119912284/job/60731083339?pr=111#step:15:9469. It is possible the flag is not passed, or overridden by pytorch.

Copilot AI review requested due to automatic review settings January 19, 2026 04:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@wdconinc
Copy link
Contributor Author

PyTorch 2.9.0 failure with GCC-14 is also at pytorch/pytorch#172445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants