-
Notifications
You must be signed in to change notification settings - Fork 4
chore: py-torch-2.7.1 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to upgrade the py-torch package requirement from version 2.5.1 to version 2.7.1 or later, with the stated goals of unpinning py-sympy used by acts and supporting newer CUDA versions.
Key Changes:
- Modified py-torch version constraint from a pinned version '@2.5.1' to a minimum version requirement '@2.7.1:'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c568e7f to
d87bd16
Compare
|
Despite the cxxflags, there are still incompatible-pointer type errors for arm64, https://github.com/eic/containers/actions/runs/21119912284/job/60731083339?pr=111#step:15:9469. It is possible the flag is not passed, or overridden by pytorch. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
da26ea4 to
e5e73e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
|
PyTorch 2.9.0 failure with GCC-14 is also at pytorch/pytorch#172445 |
Briefly, what does this PR introduce?
This PR upgrades py-torch to 2.7.1 or later (to unpin py-sympy used by acts, and to support newer CUDA).