Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR upgrade DD4hep to 1.34.

Copilot AI review requested due to automatic review settings January 21, 2026 21:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the DD4hep detector description toolkit from version 1.33 to version 1.34 by adding the necessary cherry-pick from the spack-packages repository and updating the version constraint in the Spack environment configuration.

Changes:

  • Added cherry-pick for DD4hep 1.34 from spack-packages repository
  • Updated DD4hep version requirement from 1.33 to 1.34 in packages.yaml

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
spack-packages.sh Added cherry-pick commit hash cfa8d65 with descriptive comment for DD4hep version 1.34
spack-environment/packages.yaml Updated DD4hep version constraint from '@1.33' to '@1.34'

@wdconinc wdconinc requested a review from veprbl January 22, 2026 21:29
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veprbl
Copy link
Member

veprbl commented Jan 25, 2026

Let's merge after 26.02

@wdconinc
Copy link
Contributor Author

Capybara is report is clean https://veprbl.github.io/capybara-reports/b2f42e1d040ac39d693d8d64d7437003/

Is this something we could turn into a CI check somehow?

@veprbl
Copy link
Member

veprbl commented Jan 25, 2026

Capybara is report is clean https://veprbl.github.io/capybara-reports/b2f42e1d040ac39d693d8d64d7437003/

Is this something we could turn into a CI check somehow?

My way is too far from it. We could try to make capybara capy support gitlab and use it to make comparison benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants