fix(ci): explicitly required edm4eic cxxstd=20 in user_spack_environment #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in the user_spack_environment CI job by explicitly specifying the cxxstd=20 variant for edm4eic@git.main. The issue occurred because while packages.yaml requires cxxstd=20 for edm4eic@8.6.0, this requirement doesn't automatically apply to the @git.main version used in the test environment.
Changes:
- Added
cxxstd=20variant to thespack add edm4eic@git.maincommand in the GitLab CI configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR ensures that for edm4eic@main (until the next release, when we can update the default) we use the required cxxstd=20. Addresses https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/7166992#L506.
What kind of change does this PR introduce?