Start wip to reflect user function grpc server#19
Conversation
|
This is a Draft. |
sleipnir
requested review from
marcellanz and
ralphlaude
and removed request for
marcellanz and
ralphlaude
Co-authored-by: Marcel Lanz <marcellanz@n-1.ch>
…m/eigr/massa into wip/expose-userfunc-grpc-contract
| default: 8080, map: &String.to_integer/1, required: false}, | ||
| {:user_function_uds_enable, "PROXY_UDS_MODE", default: false, required: false}, | ||
| {:user_function_sock_addr, "PROXY_UDS_ADDRESS", | ||
| default: "/var/run/cloudstate.sock", required: false}, |
There was a problem hiding this comment.
why is it needed /var/run/cloudstate.sock?
There was a problem hiding this comment.
Our proxy has the ability to communicate with the user role via unix domain sockets, in theory faster than going over the network. This can be seen and tested using the Python support language (not via branch master). There was a long discussion on this topic in some cloudstate forum (gitter or github) that I don't remember exactly anymore.
This is a path to the domain socket in the host
There was a problem hiding this comment.
I remember the discussion regarding the unix domain sockets. Thanks for the explanation :)
| @@ -0,0 +1,228 @@ | |||
| // Copyright 2020 Google LLC | |||
There was a problem hiding this comment.
nice authentication with pb 👍
There was a problem hiding this comment.
In fact, this only exists to avoid unnecessary compilations at run time, so it is included at compile time. Look at here
|
@marcellanz @ralphlaude I think we can close this one and open another one just for grpc reflection to complete the items that come from #13 |
marcellanz
left a comment
marcellanz
left a comment
There was a problem hiding this comment.
awesome stuff Adriano, really great. 🚀❤️
|
Great :) @sleipnir 🚀 |
3 participants
No description provided.