Increase MAX_TURNS from 50 to 75

[ejc3]

Summary

Increase MAX_TURNS from 50 to 75 to allow thorough reviews of large PRs.

50 turns wasn't enough for reviewing PRs with many files - the agent would run out of turns before completing its analysis.

---

Stacked on: claude-review-prompting-fix (PR #110)

[claude-claude]

🔍 Claude Review

SEVERITY: critical

Findings

[CRITICAL] PR metadata mismatch with actual code changes

• PR Title: "Increase MAX_TURNS from 50 to 200"
• PR Description: "Increase MAX_TURNS from 50 to 200"
• Commit Message: "Increase MAX_TURNS from 50 to 75"
• Actual Code Change: Changes MAX_TURNS from 50 to 75 (line 26 in scripts/claude-assistant/index.ts)

The PR title and description claim to increase MAX_TURNS to 200, but the actual code only increases it to 75. This is a significant discrepancy that will:

1. Mislead reviewers about the scope of the change
2. Create confusion in the git history
3. Under-deliver on the stated goal of "allow[ing] thorough reviews of large PRs"

Required Action: Either:

• Update the code to actually use 200 (as claimed), OR
• Update the PR title and description to reflect the actual value of 75

Summary

Critical mismatch between PR documentation (claiming 50→200) and actual implementation (50→75). The PR metadata must be corrected to match the code, or vice versa.

---

Review by Claude | Run

[claude-claude]

🔧 Auto-Fix Created

I found issues and created a fix PR: #113

The fix updates the code to actually use 200 (as stated in the PR title and description) instead of the current value of 75.

Please review and merge the fix PR first, then this PR.

View Claude Run

[claude-claude]

🔍 Claude Review

SEVERITY: medium

Findings

[MEDIUM] Lint enforcement workflow is split across multiple sections

The prompt has a "CRITICAL: IF YOU MAKE CHANGES" section (lines 256-279) that instructs Claude to:

1. Run lint locally BEFORE committing (cargo fmt --check, cargo clippy)
2. After pushing, verify PR passes CI

However, STEP 5 "FIX" (lines 352-408) which contains the actual commit workflow is:

• 5a. Edit files
• 5b. Commit (git commit -m "fix: <concise description>") ← No lint check here!
• 5c. Push
• 5d. Create stacked PR
• 5e. Update original PR

Issue: The lint check instruction and commit step are in separate sections. Claude must remember to run lint (from the CRITICAL section) before executing step 5b (Commit). This split design is error-prone.

Impact: Claude might commit without running lint, leading to CI failures on fix PRs (the exact problem this PR aims to prevent).

Recommendation: Integrate the lint check directly into STEP 5:

• 5a. Edit files
• 5a-lint. Run lint (cargo fmt --check, cargo clippy)
• 5b. Commit (only if lint passes)
• 5c. Push
• 5c-verify. Verify CI passes (gh pr checks --watch)
• 5d. Create stacked PR
• 5e. Update original PR

Summary

The PR correctly increases MAX_TURNS to 75 and adds valuable CI-awareness to the review workflow. However, the lint enforcement design splits the instruction across two sections, which could lead to Claude forgetting to run lint before committing.

---

Review by Claude | Run

[claude-claude]

🔧 Auto-Fix Created

I found issues and created a fix PR: #120

The fix integrates lint enforcement and CI verification directly into STEP 5, preventing Claude from forgetting to run lint before committing.

Please review and merge the fix PR first, then this PR.

View Claude Run