fix: make signal handler async-signal-safe#116
Closed
claude-claude[bot] wants to merge 2 commits intotty-interactive-modefrom
Closed
fix: make signal handler async-signal-safe#116claude-claude[bot] wants to merge 2 commits intotty-interactive-modefrom
claude-claude[bot] wants to merge 2 commits intotty-interactive-modefrom
Conversation
Replace Mutex with static mut + AtomicBool for signal-safe terminal restoration. Use sigaction() instead of deprecated signal() API. Fixes: - [CRITICAL] Signal handler deadlock when using Mutex::lock() - [CRITICAL] Undefined behavior from using signal() in multithreaded code - [MEDIUM] Clarify reader_loop control flow comment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #108
Issues Fixed
[CRITICAL] Signal handler async-signal-safety
Mutex::lock(), which can deadlock if signal arrives while main thread holds mutexMutex<Option<(i32, libc::termios)>>withstatic mut+AtomicBoolfor lock-free access[CRITICAL] Deprecated signal() API
libc::signal()has undefined behavior in multithreaded code per POSIXlibc::sigaction()for proper POSIX-compliant signal handling[MEDIUM] Control flow clarity
reader_loopto clarify when line 277 is reachableChanges
Mutexwithstatic mut ORIG_FD+static mut ORIG_TERMIOS_DATA+AtomicBoolsignal()withsigaction()for signal handler installationMuteximportTechnical Details
Why this is safe:
static mutwrites only happen during setup (before signal handlers installed) and cleanup (after handlers disabled)Testing:
Generated by Claude | Review Run