fix: omit deprecated enable_diff_snapshots parameter#191
Closed
claude-claude[bot] wants to merge 1 commit intodiff-snapshotfrom
Closed
fix: omit deprecated enable_diff_snapshots parameter#191claude-claude[bot] wants to merge 1 commit intodiff-snapshotfrom
claude-claude[bot] wants to merge 1 commit intodiff-snapshotfrom
Conversation
Change enable_diff_snapshots from Some(false) to None to completely omit the deprecated Firecracker parameter from the API request. The struct has #[serde(skip_serializing_if = "Option::is_none")], so None values aren't sent in the API request at all. This is cleaner than explicitly sending false for a deprecated parameter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Owner
|
Closing: base branch (diff-snapshot) has been merged to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #188
Issues Fixed
enable_diff_snapshots: Some(false)toenable_diff_snapshots: Noneto completely omit the deprecated Firecracker parameter from API requestsChanges
Updated
restore_from_snapshot()insrc/commands/common.rs:enable_diff_snapshots: Some(false)toenable_diff_snapshots: NoneWhy This Matters
The struct has
#[serde(skip_serializing_if = "Option::is_none")], soNonevalues aren't sent in the API request at all. This is cleaner than explicitly sending false for a deprecated parameter and avoids any interaction with the deprecated Firecracker API.Generated by Claude | Review Run