fix: add retry loop for nginx startup in port forward tests#213
Closed
claude-claude[bot] wants to merge 3 commits intowork-from-mainfrom
Closed
fix: add retry loop for nginx startup in port forward tests#213claude-claude[bot] wants to merge 3 commits intowork-from-mainfrom
claude-claude[bot] wants to merge 3 commits intowork-from-mainfrom
Conversation
Add slirp_ipv6 test module with tests for: - libslirp version detection (4.7+ supports native IPv6 DNS) - DNS resolution in VMs - IPv6 connectivity on eth0 Change health check default: don't auto-assign HTTP health check URL from network config. HTTP health checks require an HTTP server in the container. Use container-ready file mechanism by default instead. Users can explicitly set --health-check for HTTP checks. Also add find_available_port() helper to tests/common for port scanning. Tested: make test-root FILTER=slirp_ipv6 - all 3 tests pass make test-root FILTER=sanity - sanity test still passes
- Switch from wget to curl for HTTPS testing (busybox wget doesn't properly support HTTPS through HTTP proxy) - Use dynamic port allocation (find_available_high_port) instead of hardcoded 8080 to avoid conflicts with system services - Add --vm flag to clone tests for nslookup/curl (run in VM, not container) - Update test URLs: google.com → facebook.com, httpbin.org → checkip.amazonaws.com Tests verified: test_egress_fresh_rootless - passed test_exec_rootless - passed test_port_forward_rootless - passed
The PR changed health checks from HTTP-based (which verified nginx was responding) to container-ready file (which only verifies container started). This causes a race condition where the container is marked healthy but nginx hasn't finished binding to port 80 yet. Add 30-second retry loops with 500ms intervals to both test_port_forward_bridged and test_port_forward_rootless, giving nginx time to start after the container becomes ready. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
4 tasks
Owner
|
Not needed - pasta was removed from branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Fixes CI #21615994113
Problem
Tests
test_port_forward_rootlessandtest_port_forward_bridgedwere flaky, sometimes passing on retry but other times failing all 3 attempts. The tests would fail with "Rootless port forwarding via loopback IP should work" / "Direct access to guest should work".Root cause: PR #212 changed health checks from HTTP-based (which verified nginx was responding on port 80) to container-ready file mechanism (which only verifies the container started). This created a race condition where:
This is why the tests were flaky - sometimes nginx was fast enough, sometimes not.
Solution
Added 30-second retry loops (with 500ms intervals) to both port forwarding tests. The tests now:
This aligns with the new health check behavior while ensuring tests reliably verify port forwarding functionality.
Generated by Claude | Fix Run