fix: remove --pids-limit=0 to fix pjdfstest truncate failures#225
Closed
claude-claude[bot] wants to merge 1 commit intohttp-proxyfrom
Closed
fix: remove --pids-limit=0 to fix pjdfstest truncate failures#225claude-claude[bot] wants to merge 1 commit intohttp-proxyfrom
claude-claude[bot] wants to merge 1 commit intohttp-proxyfrom
Conversation
The --pids-limit=0 flag was causing test_pjdfstest_vm_truncate to fail consistently (test #15 in truncate/00.t). While it was added to avoid cgroup pids controller errors, disabling pids limits entirely can cause unexpected behavior in tests that rely on proper process constraints. The wait_for_cgroup_controllers() function should be sufficient to ensure pids controller is available before starting containers, making the --pids-limit=0 workaround unnecessary. Fixes test failure in CI run #21682225880
7 tasks
Owner
|
Fix cherry-picked into http-proxy branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Fixes CI #21682225880
Problem
The test
test_pjdfstest_vm_truncatewas failing consistently (all 3 retry attempts) with test #15 intruncate/00.tfailing. This was caused by the--pids-limit=0flag added in commit ff84469.While
--pids-limit=0was intended to avoid cgroup pids controller errors by disabling pids limits entirely, it caused unexpected behavior in POSIX compliance tests that may rely on proper process constraints and resource limits.Solution
Removed the
--pids-limit=0flag from podman arguments in fc-agent. The existingwait_for_cgroup_controllers()function should be sufficient to ensure the pids controller is available in the root cgroup's subtree_control before starting containers.This allows containers to use proper process limits while still handling the cgroup initialization race condition through the wait mechanism.
Testing
test_pjdfstest_vm_truncate(test Rust packaging for cargo install #15 in truncate/00.t)Generated by Claude | Fix Run