fix: correct ensure_nested_container doc comment#394
Closed
claude-claude[bot] wants to merge 1 commit intofix-podman-build-racefrom
Closed
fix: correct ensure_nested_container doc comment#394claude-claude[bot] wants to merge 1 commit intofix-podman-build-racefrom
claude-claude[bot] wants to merge 1 commit intofix-podman-build-racefrom
Conversation
…vior The doc said "Skips the build if another process already built the image" but the code always runs podman build (relying on layer caching). Updated to accurately describe the behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
Owner
|
Cherry-picked into PR #393 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #393
Issues Fixed
ensure_nested_containerclaimed "Skips the build if another process already built the image" but the code always runspodman build(relying on layer caching). Updated doc to accurately say "Redundant builds are fast due to podman's layer caching."Changes
tests/common/mod.rs: Fixed one line in theensure_nested_containerdoc comment to match actual behavior.Generated by Claude | Review Run