Conversation
This was referenced Dec 28, 2025
- Add spawn_log_consumer_with_logger functions to write test output to /tmp/fcvm-test-logs/ for CI artifact debugging - Update test_fuse_in_vm_matrix.rs to use file logging - Update test_fuse_copy_file_range_vm.rs to use file logging - Update test_remap_file_range.rs to use file logging - Increase pjdfstest timeout from 600s to 900s (15 min) to account for ~6 min skopeo import on x86_64 Now all VM tests write logs to files that are uploaded as CI artifacts.
ejc3
changed the title
Main branch is now protected - all changes must go through PRs. Added quick reference table for common git/gh commands.
PRs must include actual evidence that changes work: - Before/after output for fixes - Actual test commands and results - Not vague claims like 'tested and works'
- Local test output is good evidence (don't need CI first) - Be reasonable about detail level - Simpler examples
Container job passes. Host job fails because: - Inception tests need ARM64 FEAT_NV2 (nested virt) - pjdfstest has slow skopeo import + shutdown hangs - Various rootless tests fail on x86_64 Tested: Container job passed in run 20559660080
ejc3
added a commit
that referenced
this pull request
Mar 2, 2026
Fix CI: Update GitHub Actions, fix issues, add test logging
ejc3
added a commit
that referenced
this pull request
Mar 2, 2026
Fix CI: Update GitHub Actions, fix issues, add test logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple CI issues and improves test debugging.
Changes
1. GitHub Actions Updates
actions/checkout@v4→actions/checkout@v6(14 occurrences in ci.yml, 3 in nightly.yml)actions/upload-artifact@v4→actions/upload-artifact@v6(2 occurrences in ci.yml, 1 in nightly.yml)2. CI Fixes
cargo fmt --all --checktocargo fmt -p fcvm -p fuse-pipe -p fc-agent --check--allwas checking fuse-backend-rs (external dep) which has different formattingCONTAINER_RUNto use conditionalTARGET_MOUNTCARGO_CACHE_DIR/targetand/tmp/fcvm-container-targetwere mounting to same path3. Test Logging
spawn_log_consumer_with_logger()functions to write VM test output to filestest_fuse_in_vm_matrix.rs(pjdfstest)test_fuse_copy_file_range_vm.rstest_remap_file_range.rs/tmp/fcvm-test-logs/and uploaded as CI artifacts4. Timeout Increase
5. Documentation
Test Evidence
Lint job passes (cargo fmt fix):
Container job passes (mount fix):
Logs appear in artifacts:
Files Changed
.github/workflows/ci.yml.github/workflows/nightly.ymlMakefiletests/common/mod.rstests/test_fuse_in_vm_matrix.rstests/test_fuse_copy_file_range_vm.rstests/test_remap_file_range.rs.claude/CLAUDE.mdSupersedes Dependabot PRs #6 and #7.