fix: correct --no-dirty-tracking docs and add fd00::/64 to ss -K filter#537
Closed
claude-claude[bot] wants to merge 1 commit intorouted-mode-fixesfrom
Closed
fix: correct --no-dirty-tracking docs and add fd00::/64 to ss -K filter#537claude-claude[bot] wants to merge 1 commit intorouted-mode-fixesfrom
claude-claude[bot] wants to merge 1 commit intorouted-mode-fixesfrom
Conversation
- Fix misleading CLI help and code comments that claimed --no-dirty-tracking enables memory page sharing between clones. Per DESIGN.md's empirical data, MAP_PRIVATE CoW still copies pages to Private_Clean regardless of dirty tracking. The flag reduces KVM bitmap overhead but does not enable sharing. - Add fd00::/64 (pasta ULA IPv6) to the ss -K exclusion filter so IPv6 gateway connections are preserved after snapshot restore, matching the detection logic that already classifies [fd00: as local. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ejc3
force-pushed
the
routed-mode-fixes
branch
2 times, most recently
from
17014b7 to
9bd8bc4
Compare
Owner
|
Superseded by fixes in #536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #536
Issues Fixed
[MEDIUM]
--no-dirty-trackingCLI help text contradicts DESIGN.md: The CLI description and code comments incorrectly claimed that disabling dirty tracking enables memory page sharing between clones. DESIGN.md's own empirical data shows MAP_PRIVATE CoW still copies pages to Private_Clean regardless of dirty tracking. Updated all descriptions to accurately state the flag reduces KVM bitmap overhead.[MEDIUM]
ss -Kfilter missingfd00::/64exclusion: The detection logic correctly classified[fd00:connections as local, but thess -Kfilter didn't exclude them. Addedfd00::/64to the filter (ss accepts bare IPv6 CIDR syntax without brackets). Fixed the incorrect comment that claimed fd00:: traffic was preserved by the10.0.2.0/24IPv4 rule.Changes
src/cli/args.rs: Updated--no-dirty-trackinghelp text to describe KVM bitmap overhead reduction instead of false sharing claimsrc/commands/snapshot.rs: Updated dirty tracking code commentsrc/commands/common.rs: UpdatedRestoreParams::track_dirty_pagesdoc commentfc-agent/src/network.rs: Addedfd00::/64toss -Kexclusion filter, fixed commentGenerated by Claude | Review Run