fix: remove dead nsenter branch and update stale comments/docs#542
Closed
claude-claude[bot] wants to merge 1 commit intofix-remaining-flakyfrom
Closed
fix: remove dead nsenter branch and update stale comments/docs#542claude-claude[bot] wants to merge 1 commit intofix-remaining-flakyfrom
claude-claude[bot] wants to merge 1 commit intofix-remaining-flakyfrom
Conversation
After PR #541 switched rootless baselines to use pre_exec setns, the nsenter code path in VmManager::start() became unreachable (user_namespace_path is always set when holder_pid is set). Remove the dead branch and update all stale comments and DESIGN.md to reflect that ALL rootless VMs now use pre_exec setns. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ejc3
force-pushed
the
fix-remaining-flaky
branch
from
348aaaf to
364759d
Compare
Owner
|
Fixed in #541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #541
Issues Fixed
VmManager::start()— after PR fix: pdeathsig, namespace timeout, arping for remaining flaky tests #541 switched rootless baselines to pre_exec setns,user_namespace_pathis always set whenholder_pidis set, making theelse if let Some(holder_pid)branch unreachableholder_pid,user_namespace_path,net_namespace_pathcomments to reflect current usage (all rootless VMs, not just clones)set_holder_pid(),set_user_namespace_path(),set_net_namespace_path()docs to accurately describe the pdeathsig motivation and that these are used for all rootless VMsChanges
src/firecracker/vm.rs: Remove dead nsenter branch (~25 lines), update all related comments and doc commentsDESIGN.md: Update rootless setup sequence step 5Generated by Claude | Review Run