fix: update remaining stale comments for pre_exec setns change#544
Closed
claude-claude[bot] wants to merge 2 commits intofix-remaining-flakyfrom
Closed
fix: update remaining stale comments for pre_exec setns change#544claude-claude[bot] wants to merge 2 commits intofix-remaining-flakyfrom
claude-claude[bot] wants to merge 2 commits intofix-remaining-flakyfrom
Conversation
Update struct field comments, doc comments, and block comments in vm.rs to reflect that pre_exec setns is now used for ALL rootless VMs (not just clones), and that the primary motivation is PR_SET_PDEATHSIG preservation. Update DESIGN.md step 5 to match actual implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ejc3
force-pushed
the
fix-remaining-flaky
branch
4 times, most recently
from
bce94ff to
61eb802
Compare
Owner
|
Stale comments already fixed in #541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #541
Issues Fixed
holder_pidcomment from "use nsenter to run FC" to "health checks, cleanup". Updateduser_namespace_pathandnet_namespace_pathfrom "for rootless clones" to "for rootless VMs".set_user_namespace_pathdoc (lines 91-98): Updated from "for rootless clones" / "use this instead of set_holder_pid when mount namespace isolation is needed" to accurately describe PR_SET_PDEATHSIG preservation as the motivation, and that it's used for all rootless VMs.Changes
Comment-only and documentation changes — no behavioral modifications.
Generated by Claude | Review Run