make template_type optional in template config#97
Merged
Harsh-R-17 merged 1 commit intorghs-changesfrom Apr 9, 2026
Merged
Conversation
Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor
Harsh-R-17
added a commit
that referenced
this pull request
Apr 10, 2026
Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor
Harsh-R-17
added a commit
that referenced
this pull request
Apr 10, 2026
Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor
Harsh-R-17
added a commit
that referenced
this pull request
Apr 10, 2026
Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor
Harsh-R-17
added a commit
that referenced
this pull request
Apr 13, 2026
Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor
Harsh-R-17
added a commit
that referenced
this pull request
Apr 13, 2026
Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor
Harsh-R-17
added a commit
that referenced
this pull request
Apr 13, 2026
* rghs init * rghs changes * rghs changes * make template_type optional in template config (#97) Allow partial template config updates to type-check by making template_type optional instead of required. Made-with: Cursor * rghs changes Made-with: Cursor * add more changes * rghs changes Made-with: Cursor * fix(rghs): bullet column layout for PDF - Use padding + absolute bullet instead of flex on li (PDF-safe). - Prefer max font then fewest columns that fit; cap meds at 1 column. - Optional maxColumnCount for renderBulletColumns/computeBulletLayout. Made-with: Cursor * Remove TEMPLATE_TYPE enum and template_type from TemplateConfig Drop unused RGHS/EKA template type discriminator from Templar types. Made-with: Cursor * Add optional template_id to RenderPdfConfig for layout mapping. Made-with: Cursor * Add optional template_id to TemplateConfig for PDF layout routing. Made-with: Cursor * Fix medication frequency rendering for custom values. Use only the custom frequency text in rghs PDF medication lines to avoid mixing fallback frequency formats. * Allow medications section to use dynamic bullet columns. Remove the hard one-column cap so medication items can flow to additional columns when space is constrained. * more changes * more changes * remove time from rghs investigation date Made-with: Cursor * rename template_id to template_style in render config types Made-with: Cursor --------- Co-authored-by: Harsh R Gajera <harshrgajera@Harshs-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow partial template config updates to type-check by making template_type optional instead of required.
Made-with: Cursor