Ignore SSL Certs for MITM/Firewalls #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2020 11:19
…erify_mode=ssl.CERT_NONE. Unsafe but allows users behind corporate firewalls to ignore cert errors due to MITM/firewall issues.
Removed else: from urlopen to be more pythonic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option "--ignore_ssl_certs" to set ssl.SSLContext.verify_mode=ssl.CERT_NONE
This is "UNSAFE" but allows users behind corporate firewalls to bypass SSL Certificate errors from urllib.urlopen due to MITM situations.
I've written and tested these changes behind a corporate firewall on WSL (Windows Subsystems for Linux) Ubuntu 18.04 using Python 3.6 in a virtual environment.