Skip to content

Fix version discovery; #356, #357 #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekalinin merged 1 commit into from
Jun 4, 2024
Merged

Fix version discovery; #356, #357 #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion nodeenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@ def parse_version(version_str):
"""
Parse version string to a tuple of integer parts
"""
return tuple(map(int, version_str.replace('v', '').split('.')))
v = version_str.replace('v', '').split('.')[:3]
# remove all after '+' in the PATCH part of the version
if len(v) >= 3:
v[2] = v[2].split('+')[0]
return tuple(map(int, v))


def node_version_from_args(args):
Expand Down
6 changes: 6 additions & 0 deletions tests/nodeenv_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,3 +161,9 @@ def test__download_node_file():
n_attempt=5
)
assert m_urlopen.call_count == 5


def test_parse_version():
assert nodeenv.parse_version("v21.7") == (21, 7)
assert nodeenv.parse_version("v21.7.3") == (21, 7, 3)
assert nodeenv.parse_version("v21.7.3+0-b20240228T18452699") == (21, 7, 3)