Skip to content

Support leading v in .node-version #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ekalinin merged 1 commit into from
Aug 25, 2024
Merged

Support leading v in .node-version #359

ekalinin merged 1 commit into from
Aug 25, 2024

Conversation

@nix6839
Copy link
Contributor

@nix6839 nix6839 commented Jun 11, 2024

From: https://github.com/shadowspawn/node-version-usage#suggested-compatible-format

Allowing a leading v is common and gives nice symmetry with node --version

$ node --version
v20.12.0
$ node --version > .node-version

@ekalinin
Copy link
Owner

ekalinin commented Jun 11, 2024

Hey!
Thanks for the patch!
Could you add a test, please?

@nix6839 nix6839 force-pushed the node-version-leading-v branch from c53405f to 112c7af Compare June 11, 2024 17:16
@nix6839
Copy link
Contributor Author

nix6839 commented Jun 11, 2024

Could you add a test, please?

I've added the test.

@ekalinin ekalinin merged commit 4442d10 into ekalinin:master Aug 25, 2024
@nix6839 nix6839 deleted the node-version-leading-v branch August 25, 2024 11:52
@nix6839 nix6839 mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nix6839 @ekalinin