Faster with preallocated output array and remapped values in nodes#6
Open
nicolaitanes wants to merge 2 commits intoekg:masterfrom
Open
Faster with preallocated output array and remapped values in nodes#6nicolaitanes wants to merge 2 commits intoekg:masterfrom
nicolaitanes wants to merge 2 commits intoekg:masterfrom
Conversation
…ection. Starting from an array of `remap` elements is reasonably fast compared to reallocating it in each call to `visit`, which adds about 69% to the run time when the callback/body is trivial. Starting from an empty array adds about 17% to the runtime (compared to `remap` elements), probably because the JIT has to emit more array operations. Prefilling with a constant, though incorrect, is even faster than remap; maybe the runtime can pick a simpler array subclass? e.g. - p.map(() => 'why???') as unknown as T[] : runtime is about 95% compared to remap - p.slice() as unknown as T[] : runtime is about 93% compared to remap -- fastest
Nodes' positional value `v` changes infrequently, if at all. By including `r: remap[node.v]` in each node, we can save about 25% of runtime.
nicolaitanes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yielding the same array each time saves a lot of time on garbage collection.
Starting from an array of
remapelements is reasonably fast compared to reallocating it in each call tovisit, which adds about 69% to the run time when the callback/body is trivial.Starting from an empty array adds about 17% to the runtime (compared to
remapelements), probably because the JIT has to emit more array operations.Prefilling with a constant, though incorrect, is even faster than remap; maybe the runtime can pick a simpler array subclass? e.g.
p.map(() => 'why???') as unknown as T[]runtime is about 95% compared to remapp.slice() as unknown as T[]runtime is about 93% compared to remap -- the fastestUpdated 2024-09: Faster by precomputing the remapped value in each node
Nodes' positional value
vchanges infrequently, if at all.By including
r: remap[node.v]in each node, we can save about 25% of runtime.