Upgrade spf13/cobra to v1.1.0 to fix zsh completion issue#2756
Closed
ysam12345 wants to merge 1 commit into
Closed
Upgrade spf13/cobra to v1.1.0 to fix zsh completion issue#2756ysam12345 wants to merge 1 commit into
ysam12345 wants to merge 1 commit into
Conversation
michaelbeaumont
approved these changes
Oct 20, 2020
Contributor
|
Thanks! |
Contributor
|
It looks like the tests that check CLI output are failing. This is likely because the output has changed somehow between versions |
Contributor
Author
Ok, I'll look into it. |
Contributor
Author
|
@michaelbeaumont I found that is because RP spf13/cobra#894 changed some error output from stdOut to stdErr, so some of our test cases failed. I can fix it by adding stdErr to our output buffer, and all the test cases passed. |
Contributor
Author
|
Need more discuss in #2747. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Upgrade version of spf13/cobra from v1.0.0 to v1.1.0 to fix #2747
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)