Skip to content

Upgrade spf13/cobra to v1.1.1 to fix zsh completion issue#2813

Merged
weaveworksbot merged 3 commits into
eksctl-io:masterfrom
ysam12345:fix_zsh_completion_and_change_err_in_test
Nov 12, 2020
Merged

Upgrade spf13/cobra to v1.1.1 to fix zsh completion issue#2813
weaveworksbot merged 3 commits into
eksctl-io:masterfrom
ysam12345:fix_zsh_completion_and_change_err_in_test

Conversation

@ysam12345
Copy link
Copy Markdown
Contributor

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

Copy link
Copy Markdown
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go in, we should refactor these tests (see #2747 (comment))

@weaveworksbot weaveworksbot merged commit 285f53e into eksctl-io:master Nov 12, 2020
@michaelbeaumont
Copy link
Copy Markdown
Contributor

Thanks @ysam12345 !

@ysam12345
Copy link
Copy Markdown
Contributor Author

@michaelbeaumont I’m happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zsh autocomplete error when calling eksctl create nodegroup - invalid option definition

3 participants