feat: Use explicit lifetime for RpcFunc, thus allowing non-static lifetimes#5
Merged
frol merged 1 commit intoelast0ny:masterfrom Oct 15, 2020
Merged
Conversation
…etimes This change is not effective if you spawn `evt_loop` with `tokio::spawn` as the latter requires `'static` lifetime, and it poisones the client, and the core with `'static` requirement. I ended up using `Arc` for the context state anyway, so these changes are not solving any particular issue, but I still think it might be worth having it specified this way to potentially relax some future use-cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is not effective if you spawn
evt_loopwithtokio::spawnas the latter requires'staticlifetime, so it poisons the client, and the core with'staticrequirement. I ended up usingArcfor the context state anyway, so these changes are not solving any particular issue, but I still think it might be worth having it specified this way to potentially relax some future use-cases.