Rename estc-downstream-health to internal-downstream-health#515
Rename estc-downstream-health to internal-downstream-health#515
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThis pull request renames the "Estc Downstream Health" workflow to "Internal: Downstream Health" across the codebase. It updates all references including workflow file paths (gh-aw-estc-downstream-health.lock.yml to gh-aw-internal-downstream-health.lock.yml), environment variables, concurrency group identifiers, documentation, and example files. The change introduces a new 1496-line workflow file and maintains backwards compatibility through deprecation notices in the renamed file and updates to the backwards-compatibility script. Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Two blocking issues need correction before merge:
.github/workflows/smoke-test-install.yml:57— the new entryinternal-downstream-healthis consumed bygh-aw add ".../.github/workflows/gh-aw-${wf}.md"(:88), which resolves togh-aw-internal-downstream-health.md. The actual shim isinternal-downstream-health.md, so this install path is invalid and the smoke test will fail for this workflow.gh-agent-workflows/internal-downstream-health/README.md:13-15— the quick-install command has a blank line immediately after a trailing\, which breaks shell line continuation and makes the snippet fail when copied.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/smoke-test-install.yml:
- Line 57: The WORKFLOWS array includes "internal-downstream-health" but the
installer loop constructs filenames as `gh-aw-${wf}.md`, causing a missing-file
error for workflows without that prefix; update the loop in the
smoke-test-install workflow to either skip/handle entries that already start
with "internal-" (e.g., detect wf.startsWith('internal-') and use `${wf}.md`
instead of `gh-aw-${wf}.md`) or remove "internal-downstream-health" from the
WORKFLOWS array so only prefixed items are processed; adjust the filename
construction logic and any conditional branching around the loop to ensure both
prefixed and internal workflows resolve to the correct markdown filename.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.github/workflows/gh-aw-estc-downstream-health.lock.yml.github/workflows/internal-downstream-health.lock.yml.github/workflows/internal-downstream-health.md.github/workflows/smoke-test-install.yml.github/workflows/trigger-internal-downstream-health.ymldocs/blog/posts/meet-the-watchdogs.mddocs/upgrading.mddocs/workflows/gh-agent-workflows.mdgh-agent-workflows/README.mdgh-agent-workflows/internal-downstream-health/README.mdgh-agent-workflows/internal-downstream-health/example.ymlmkdocs.ymlscripts/backwards-compat.sh
💤 Files with no reviewable changes (2)
- mkdocs.yml
- docs/workflows/gh-agent-workflows.md
| estc-docs-patrol-external | ||
| estc-docs-pr-review | ||
| estc-downstream-health | ||
| internal-downstream-health |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check for both filename variants
echo "=== Looking for internal-downstream-health files ==="
fd -t f "internal-downstream-health" .github/workflows --extension md
echo -e "\n=== Looking for any gh-aw-internal-downstream-health files ==="
fd -t f "gh-aw-internal-downstream-health" .github/workflows --extension md
echo -e "\n=== Context around line 88 of smoke-test-install.yml ==="
sed -n '80,95p' .github/workflows/smoke-test-install.ymlRepository: elastic/ai-github-actions
Length of output: 782
🏁 Script executed:
# Get the full WORKFLOWS array definition
sed -n '70,87p' .github/workflows/smoke-test-install.yml
echo -e "\n=== All internal-* workflows in .github/workflows ==="
fd -t f "^internal-" .github/workflows --extension mdRepository: elastic/ai-github-actions
Length of output: 661
🏁 Script executed:
# Get the full context around line 57
sed -n '50,75p' .github/workflows/smoke-test-install.ymlRepository: elastic/ai-github-actions
Length of output: 904
🏁 Script executed:
# Check how the other workflows are named
echo "=== All gh-aw-* workflow files ==="
fd -t f "^gh-aw-" .github/workflows --extension md | head -20
echo -e "\n=== Confirm internal-* workflows don't have gh-aw prefix ==="
fd -t f "^(internal-|gh-aw-internal-)" .github/workflows --extension mdRepository: elastic/ai-github-actions
Length of output: 1330
🏁 Script executed:
# Check if internal-gemini-cli is also in the WORKFLOWS array
grep "internal-gemini-cli" .github/workflows/smoke-test-install.ymlRepository: elastic/ai-github-actions
Length of output: 51
Fix path mismatch for internal-downstream-health workflow.
Line 88 constructs paths as gh-aw-${wf}.md, but internal-downstream-health.md doesn't have the gh-aw- prefix. This will cause the smoke test to fail with a file-not-found error when attempting to install it.
Either exclude internal-downstream-health from the WORKFLOWS array or handle internal workflows separately in the loop.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/smoke-test-install.yml at line 57, The WORKFLOWS array
includes "internal-downstream-health" but the installer loop constructs
filenames as `gh-aw-${wf}.md`, causing a missing-file error for workflows
without that prefix; update the loop in the smoke-test-install workflow to
either skip/handle entries that already start with "internal-" (e.g., detect
wf.startsWith('internal-') and use `${wf}.md` instead of `gh-aw-${wf}.md`) or
remove "internal-downstream-health" from the WORKFLOWS array so only prefixed
items are processed; adjust the filename construction logic and any conditional
branching around the loop to ensure both prefixed and internal workflows resolve
to the correct markdown filename.
Drop the gh-aw- prefix for internal workflows (convention: gh-aw- for public, internal- for private/use-at-your-own-risk, no prefix for repo-only). Updates all references, adds backwards-compat copy, and removes from public docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
strawgate
force-pushed
the
feat/internal-downstream-health
branch
from
2d72425 to
c242b37
Compare
- Rename gh-aw-internal-downstream-health.md → internal-downstream-health.md - Rename gh-aw-internal-downstream-health.lock.yml → internal-downstream-health.lock.yml - Update backwards-compat.sh to point to internal-downstream-health.lock.yml - Update trigger, example.yml, and upgrading.md references - Remove internal-downstream-health from smoke-test-install (internal workflow) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
strawgate
force-pushed
the
feat/internal-downstream-health
branch
from
c242b37 to
c856600
Compare
1 participant
Summary
gh-aw-estc-downstream-healthtointernal-downstream-health..github/workflows/gh-aw-estc-downstream-health.lock.ymlas a backward-compatibility copy with a deprecation header pointing to.github/workflows/internal-downstream-health.lock.yml..github/workflows/internal-downstream-health.md.github/workflows/trigger-internal-downstream-health.ymlgh-agent-workflows/internal-downstream-health/{README.md,example.yml}gh-agent-workflows/README.md,docs/upgrading.md, docs blog/workflow pages, andscripts/backwards-compat.sh).mkdocs.yml,docs/workflows/gh-agent-workflows.md) and lists it under Internal Workflows ingh-agent-workflows/README.md.Naming convention
gh-aw-*internal-*Test plan
make compilesucceeds — newinternal-downstream-health.lock.ymlgeneratedscripts/backwards-compat.shestc-downstream-healthreferences are limited to migration/compatibility files