Support updatecli in gh-aw-dependency-review#533
Conversation
Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
|
@copilot doesnt that workflow have an allowed bots list we also need to put that in? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR extends the dependency review workflow to support Updatecli alongside existing Dependabot and Renovate integrations. Changes include: adding Updatecli branch detection via Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Good catch! The compiled lock.yml does have an |
| github.event.pull_request.user.login == 'dependabot[bot]' || | ||
| github.event.pull_request.user.login == 'renovate[bot]' | ||
| github.event.pull_request.user.login == 'renovate[bot]' || | ||
| startsWith(github.head_ref, 'updatecli') |
There was a problem hiding this comment.
[HIGH] Updatecli trigger can fail authorization in called workflow
This adds startsWith(github.head_ref, 'updatecli'), but this caller still invokes gh-aw-dependency-review.lock.yml without passing allowed-bot-users, while the called workflow allowlist is $\{\{ inputs.allowed-bot-users }},dependabot[bot],renovate[bot] and defaults allowed-bot-users to github-actions[bot]. For repo-installed Updatecli bots (commonly custom bot usernames), the workflow will trigger here but then fail activation/membership checks and skip dependency analysis.
Please pass the PR bot login through with.allowed-bot-users (or explicitly include Updatecli bot identities) in this workflow call so the new trigger path is actually executable.
gh-aw-dependency-reviewpreviously triggered only for Dependabot/Renovate PRs. This updates the trigger logic to also include Updatecli PRs, using branch-name detection because Updatecli bot usernames are installation-specific while branch names are consistently prefixed withupdatecli.Changes
Updated trigger conditions in:
.github/workflows/trigger-dependency-review.ymlgh-agent-workflows/dependency-review/example.ymlAdded
startsWith(github.head_ref, 'updatecli')alongside existing bot-user checks.Updated
.github/workflows/gh-aw-dependency-review.mdtext to explicitly include Updatecli in the workflow description and agent prompt.Updated docs to reflect the expanded trigger coverage:
gh-agent-workflows/dependency-review/README.mddocs/workflows/gh-agent-workflows.mdFixes Support updatecli for the dependency agentic workflow called
gh-aw-dependency-review#532